Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client/cordova/apple/macos): fix popover click and location issues #1845

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Feb 21, 2024

I think this fixes the following popover issues on macos:

This should allow us to release a fixed old macos client while we try to resolve the VpnExtension's gomobile issues for Catalyst on arm64.

@sbruens sbruens requested a review from a team as a code owner February 21, 2024 06:24
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (385ae8f) 32% compared to head (166ae71) 32%.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           sbruens/server-list-lit   #1845   +/-   ##
=======================================================
  Coverage                       32%     32%           
=======================================================
  Files                           45      45           
  Lines                         2610    2610           
  Branches                       337     337           
=======================================================
  Hits                           859     859           
  Misses                        1751    1751           
Flag Coverage Δ
apple 15% <ø> (ø)
maccatalyst 15% <ø> (ø)
macos 15% <ø> (ø)
unittests 32% <ø> (ø)
www 40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fortuna
Copy link
Collaborator

fortuna commented Feb 21, 2024

Any idea why the iOS build is failing? It seems the other PR is failing too.

@daniellacosse
Copy link
Contributor

Any idea why the iOS build is failing? It seems the other PR is failing too.

I think they all are. Some third party thing must have broken?

Base automatically changed from sbruens/server-list-lit to master February 22, 2024 15:17
@sbruens sbruens changed the title fix(cordova/apple/macos): fix popover click and location issues fix(client/cordova/apple/macos): fix popover click and location issues Feb 22, 2024
@sbruens sbruens merged commit 3bf9d6d into master Feb 22, 2024
22 of 24 checks passed
@sbruens sbruens deleted the sbruens/macos-click branch February 22, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants