-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client/cordova/apple/macos): fix popover click and location issues #1845
Conversation
…stead of assuming responsibility for closing the popover in the app.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sbruens/server-list-lit #1845 +/- ##
=======================================================
Coverage 32% 32%
=======================================================
Files 45 45
Lines 2610 2610
Branches 337 337
=======================================================
Hits 859 859
Misses 1751 1751
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Any idea why the iOS build is failing? It seems the other PR is failing too. |
I think they all are. Some third party thing must have broken? |
I think this fixes the following popover issues on macos:
This should allow us to release a fixed old macos client while we try to resolve the VpnExtension's gomobile issues for Catalyst on arm64.