Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced FileSaver with JSaver for windows support #12

Closed
wants to merge 2 commits into from

Conversation

Tamunorth
Copy link

This is a fix for #11

@JideGuru
Copy link
Owner

JideGuru commented Jan 6, 2023

Sadly I currently do not own a Windows computer so I can't really review the windows part😢.
Please add a short video showing what you just fixed. Thanks

@Tamunorth
Copy link
Author

2023-01-08.20-37-56_Trim.mp4

@Tamunorth
Copy link
Author

@JideGuru Sorry i didn't respond earlier, I missed the mail from github, The app on the left is the current master branch, when export is tapped noting happens on windows, the one on the left actually works which is the fix.

@JideGuru
Copy link
Owner

JideGuru commented Jan 8, 2023

@Tamunorth Really good work on the PR but I have some comments

the JSaver plugin doesn't seem to support MacOS
Screenshot 2023-01-08 at 22 13 29

But file_saver seems to support both Windows and MacOS.
Screenshot 2023-01-08 at 22 15 05

Perhaps we need to do a little config to allow file_saver to work on windows? or maybe we need to update the plugin? It'll be nice if you can help with this.

@JideGuru
Copy link
Owner

Closed as Stale

@JideGuru JideGuru closed this Nov 20, 2023
@ArchitMukherjee
Copy link

I am working on a Windows laptop and debugging on an Android emulator. Initially the drawing board was not getting saved, but I used FileSaver.instance.saveAs(...) instead of FileSaver.instance.saveFile(...) and it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants