Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix nil crashing #12

Merged
merged 5 commits into from
Mar 7, 2024
Merged

fix: fix nil crashing #12

merged 5 commits into from
Mar 7, 2024

Conversation

Jh123x
Copy link
Owner

@Jh123x Jh123x commented Mar 7, 2024 •
edited
Loading

Motivation

  • nil options will crash for composite rules.

Implementation

  • fix: fix bug where nil options will fail

Testing

  • Current unit tests cover most of the current changes.
  • New unit test to cover bug cases

Related PRs

N/A

@Jh123x Jh123x self-assigned this Mar 7, 2024
@Jh123x Jh123x changed the title feat: general improvements fix: fix nil crashing Mar 7, 2024
@Jh123x Jh123x merged commit 6fec7cd into main Mar 7, 2024
1 check passed
@Jh123x Jh123x deleted the feat/improve-validator branch March 7, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jh123x Jh123x

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jh123x