Initial generation signature feature toggle.#481
Draft
nojaf wants to merge 76 commits intoJetBrains:net232from
Draft
Initial generation signature feature toggle.#481nojaf wants to merge 76 commits intoJetBrains:net232from
nojaf wants to merge 76 commits intoJetBrains:net232from
Conversation
nojaf
commented
Feb 13, 2023
ReSharper.FSharp/src/FSharp.Psi.Intentions/src/Intentions/GenerateSignatureFileAction.fs
Outdated
Show resolved
Hide resolved
nojaf
commented
Feb 13, 2023
ReSharper.FSharp/src/FSharp.Psi.Intentions/src/Intentions/GenerateSignatureFileAction.fs
Outdated
Show resolved
Hide resolved
nojaf
force-pushed
the
generate-signature-two
branch
from
af43d0c to
45a07fe
Compare
nojaf
force-pushed
the
generate-signature-two
branch
from
90cdf95 to
ca70826
Compare
auduchinok
force-pushed
the
generate-signature-two
branch
from
08c9c23 to
95b98a0
Compare
nojaf
commented
May 2, 2023
ReSharper.FSharp/test/data/features/generate/signatureFiles/Module structure 02.fs
Outdated
Show resolved
Hide resolved
nojaf
commented
May 2, 2023
ReSharper.FSharp/src/FSharp.Psi.Services/src/Generate/GenerateSignatureProvider.fs
Outdated
Show resolved
Hide resolved
auduchinok
reviewed
May 3, 2023
ReSharper.FSharp/src/FSharp.Psi.Intentions/src/Intentions/GenerateSignatureFileAction.fs
Outdated
Show resolved
Hide resolved
ReSharper.FSharp/src/FSharp.Psi.Services/src/Generate/GenerateSignatureProvider.fs
Show resolved
Hide resolved
ReSharper.FSharp/src/FSharp.Psi.Services/src/Generate/GenerateSignatureProvider.fs
Outdated
Show resolved
Hide resolved
nojaf
force-pushed
the
generate-signature-two
branch
2 times, most recently
from
31f6605 to
8c85309
Compare
auduchinok
reviewed
May 8, 2023
ReSharper.FSharp/src/FSharp.Psi.Services/src/Generate/GenerateSignatureProvider.fs
Outdated
Show resolved
Hide resolved
auduchinok
reviewed
May 8, 2023
ReSharper.FSharp/src/FSharp.Psi.Services/src/Generate/GenerateSignatureProvider.fs
Outdated
Show resolved
Hide resolved
note, we should improve the signature with naming
note, we should improve the signature with naming
…sentation in the future, let's see.
nojaf
force-pushed
the
generate-signature-two
branch
from
b5d33d2 to
de6092e
Compare
# Conflicts: # ReSharper.FSharp/src/FSharp.Psi.Services/src/Generate/GenerateSignatureProvider.fs # ReSharper.FSharp/test/data/features/generate/signatureFiles/Delegate 01.fs # ReSharper.FSharp/test/data/features/generate/signatureFiles/Delegate 01.fs.gold # ReSharper.FSharp/test/data/features/generate/signatureFiles/Exception 01.fs # ReSharper.FSharp/test/data/features/generate/signatureFiles/Exception 01.fs.gold # ReSharper.FSharp/test/data/features/generate/signatureFiles/Instance Member 01.fs # ReSharper.FSharp/test/data/features/generate/signatureFiles/Instance Member 01.fs.gold # ReSharper.FSharp/test/data/features/generate/signatureFiles/Module structure 02.fs # ReSharper.FSharp/test/data/features/generate/signatureFiles/Module structure 02.fs.gold # ReSharper.FSharp/test/data/features/generate/signatureFiles/Nested module 01.fs # ReSharper.FSharp/test/data/features/generate/signatureFiles/Nested module 01.fs.gold # ReSharper.FSharp/test/data/features/generate/signatureFiles/Record 01.fs # ReSharper.FSharp/test/data/features/generate/signatureFiles/Record 01.fs.gold # ReSharper.FSharp/test/data/features/generate/signatureFiles/Struct 01.fs # ReSharper.FSharp/test/data/features/generate/signatureFiles/Struct 01.fs.gold # ReSharper.FSharp/test/data/features/generate/signatureFiles/Union 01.fs # ReSharper.FSharp/test/data/features/generate/signatureFiles/Union 01.fs.gold # ReSharper.FSharp/test/data/features/generate/signatureFiles/Union 02.fs # ReSharper.FSharp/test/data/features/generate/signatureFiles/Union 02.fs.gold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A second attempt at #378.