Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Deprecate functions that should be replaced by migrations #2333

Merged
merged 1 commit into from
Jan 7, 2025
Merged

chore: Deprecate functions that should be replaced by migrations #2333

merged 1 commit into from
Jan 7, 2025

Conversation

joc-a
Copy link
Collaborator

@joc-a joc-a commented Dec 12, 2024 •
edited
Loading

Description

Summary of the change: Deprecate functions that should be replaced by migrations

Detailed description:

  • Why: These schema-altering functions will be replaced by migrations.
  • How: Added WARNING deprecation level to the functions.

Type of Change

Please mark the relevant options with an "X":

  • Bug fix
  • New feature
  • Documentation update
  • Other - deprecation

Updates/remove existing public API methods:

  • Is breaking change

Affected databases:

  • MariaDB
  • Mysql5
  • Mysql8
  • Oracle
  • Postgres
  • SqlServer
  • H2
  • SQLite

Checklist

  • Unit tests are in place
  • The build is green (including the Detekt check)
  • All public methods affected by my PR has up to date API docs
  • Documentation for my change is up to date

Related Issues

EXPOSED-101

@joc-a joc-a marked this pull request as ready for review December 12, 2024 22:44
@joc-a joc-a requested review from e5l and obabichevjb December 12, 2024 22:45
@joc-a joc-a changed the title chore: Deprecate functions that should be replaced by migration functions chore: Deprecate functions that should be replaced by migrations Dec 12, 2024
e5l
e5l approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bog-walk bog-walk merged commit d763e8e into main Jan 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obabichevjb obabichevjb obabichevjb approved these changes

@e5l e5l e5l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joc-a @e5l @obabichevjb @bog-walk