Merge pull request #157 from mschaefer0815/main

Update ratios_controller.py
JerBouma · Sep 21, 2024 · e961ebb · e961ebb
2 parents b026b4a + bfe4386
commit e961ebb
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/financetoolkit/ratios/ratios_controller.py b/financetoolkit/ratios/ratios_controller.py
@@ -4910,7 +4910,7 @@ def get_earnings_per_share(
                 .sum()
                 .T,
                 dividends,
-                average_shares.T.rolling(trailing).sum().T,
+                average_shares, # Shares of current period
             )
         else:
             dividends = (
@@ -4991,7 +4991,7 @@ def get_revenue_per_share(
         if trailing:
             revenue_per_share = valuation_model.get_revenue_per_share(
                 self._income_statement.loc[:, "Revenue", :].T.rolling(trailing).sum().T,
-                average_shares.T.rolling(trailing).sum().T,
+                average_shares, # Shares of current period, alternatively average_shares.T.rolling(trailing).mean().T
             )
         else:
             revenue_per_share = valuation_model.get_revenue_per_share(
@@ -5373,7 +5373,7 @@ def get_interest_debt_per_share(
                 .T.rolling(trailing)
                 .sum()
                 .T,
-                average_shares.T.rolling(trailing).sum().T,
+                average_shares, # Shares of current period, alternatively average_shares.T.rolling(trailing).mean().T
             )
         else:
             interest_debt_per_share = valuation_model.get_interest_debt_per_share(
@@ -5451,7 +5451,7 @@ def get_capex_per_share(
                 .T.rolling(trailing)
                 .sum()
                 .T,
-                average_shares.T.rolling(trailing).sum().T,
+                average_shares, # Shares of current period, alternatively average_shares.T.rolling(trailing).mean().T
             )
         else:
             capex_per_share = valuation_model.get_capex_per_share(
@@ -5598,7 +5598,7 @@ def get_weighted_dividend_yield(
                 .T.rolling(trailing)
                 .sum()
                 .T,
-                average_shares.T.rolling(trailing).sum().T,
+                average_shares, # Shares of current period, alternatively average_shares.T.rolling(trailing).mean().T
                 share_prices,
             )
         else:
@@ -5837,7 +5837,8 @@ def get_market_cap(
 
         if trailing:
             market_cap = valuation_model.get_market_cap(
-                share_prices, average_shares.T.rolling(trailing).sum().T
+                share_prices, 
+                average_shares, # Shares of current period, alternatively average_shares.T.rolling(trailing).mean().T
             )
         else:
             market_cap = valuation_model.get_market_cap(share_prices, average_shares)