Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pageRSSLinkToClipboard to copy RSS feed links to clipboard #480

Merged
merged 2 commits into from
Jun 11, 2023

Conversation

rafael-xmr
Copy link
Contributor

a draft attempt at implementing #385 (comment), probably needs a way to select which feed to copy since this gets the first link tag and some sites can have multiple per page

peek

@Jelmerro
Copy link
Owner

Thanks for taking the time to implement this! If you could use includes instead of indexOf !== -1, as that is more in line with the rest of the code.

If multiple RRS feed links are common, maybe a separate action list them and copy a single one would be cool, and copy them by index using a mapping like yR1, yR2 etc. and then yRL or yRR that could list them. If it's not that common maybe just the first link copy would be good enough.

@rafael-xmr
Copy link
Contributor Author

Thanks! what do you think now?

peek.1.mp4

@Jelmerro
Copy link
Owner

That's very good, I like this implementation a lot. Thank you for taking the time to make this feature, it will land in V10 soon.

@Jelmerro Jelmerro merged commit 0c79faa into Jelmerro:master Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants