Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the regex of Hashtag and Mention to make it return right things #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasonyanwenl
Copy link

The function to get hashtags and mentions only returns the # or @.

The reason is that in the returned tweet, there is a space between content of hash and tag #(same as mentions). Hence the regex (#\\w*) does not work. Here it is changed to r'(#\s\w*)'. This works now.

…. The reason is that in the returned tweet, there is a space between content of hash and tag "#"(same as mentions). Hence the regex "(#\\w*)" does not work. Here it is changed to "r'(#\s\w*)'". This works now.
@LoLei
Copy link

LoLei commented Apr 13, 2019

Wouldn't it be better to just fix the issue of having the space after # and @ like this?

But that PR also contains some other stuff not related to this issue so not sure.

Also, do PRs ever get merged here anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants