Open
Conversation
Collaborator
Author
|
@tschm i will resolve conflicts but codefactor seems a bit buggy? |
tschm
approved these changes
Feb 8, 2026
Member
|
Yes, that's a weird CodeFactor problem. No issue and yet broken... |
Adds a new GitHub Actions workflow that verifies CodeFactor is functioning and accessible. The workflow fetches the CodeFactor badge, extracts the current grade, and fails if the service is unreachable or broken. This ensures CodeFactor issues are surfaced in CI/CD rather than going unnoticed. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
CodeFactor is optional and not used in private repos, so removing the CI check to avoid failures where CodeFactor isn't configured. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request reorganizes and modernizes the benchmarking and test utilities for the project. It moves benchmark analysis scripts and outputs to a unified location, updates Makefile targets to use
uv runinstead of direct Python calls, and eliminates the sharedtest_utils.pyin favor of defining utilities directly in each test module. This improves maintainability, avoids import issues, and ensures all test scripts use up-to-date paths and conventions.The most important changes include:
Benchmarking and Analysis Refactor:
analyze_benchmarks.pyfromtests/test_rhiza/benchmarks/to.rhiza/utils/, updated it to use_benchmarksas the output directory, and adjusted all paths accordingly. [1] [2].rhiza/make.d/01-test.mk) so that benchmark outputs (JSON, HTML, histogram) are written to_benchmarks/instead of inside the test directory. The analysis script is now run viauv run .rhiza/utils/analyze_benchmarks.py.tests/test_rhiza/benchmarks/README.mdand.gitignorefiles, as well as thetests/conftest.pyandtest_utils.pyutility modules, consolidating benchmark documentation and utilities. [1] [2] [3] [4]Makefile and Test Target Modernization:
uv run pytestfor running tests and generating coverage and reports, replacing direct calls to the Python interpreter in the virtual environment. Added checks for missing source or test folders, with clear warnings if they are absent. [1] [2] [3].rhiza/tests/README.mdto reflect the new location for benchmarks (tests/benchmarks/).Test Utilities Refactor:
test_utils.pyand instead defined helper functions (run_make,strip_ansi,setup_rhiza_git_repo) directly in each relevantconftest.pyfile forapiandsynctests. This eliminates the need for relative imports and ensures all test modules are self-contained. [1] [2] [3] [4]uv run pytestinstead of.venv/bin/python -m pytest. [1] [2] [3] [4]These changes collectively improve the structure, maintainability, and reliability of the project's test and benchmarking infrastructure.