Remove redundant pyproject.toml existence checks#152
Draft
Conversation
…e scripts Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove constant checks for pyproject.toml file
Remove redundant pyproject.toml existence checks
Dec 26, 2025
Member
|
@copilot remove from the Makefile |
Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
Contributor
Author
Co-authored-by: tschm <2046079+tschm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
bump.sh,release.sh, and theMakefilecheck forpyproject.tomlexistence before proceeding. This is redundant as upstream validation ensures the file exists.Changes
pyproject.tomlexistence check from.rhiza/scripts/bump.shpyproject.tomlexistence check from.rhiza/scripts/release.shpyproject.tomlexistence check fromMakefileinstall targetpyproject.tomlexistence check fromMakefiledeptry targetMakefileexplaining the pyproject.toml assumptionThe scripts and Makefile targets now proceed directly to their core functionality, reducing defensive checks that add no value.
Original prompt
<issue_description>You can assume the file exists as validate would throw an error otherwise</issue_description>
Comments on the Issue (you are @copilot in this section)
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.