Wip update to Npgsql 4.0 #1045

oskardudycz · 2018-07-14T16:49:07Z

See more about the reason of such changes in:

jacobpovar · 2018-07-16T06:36:13Z

src/Marten/Marten.csproj

@@ -27,9 +31,10 @@
    <EmbeddedResource Include="Schema\SchemaObjects.sql" />
  </ItemGroup>
  <ItemGroup>
-    <PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
+    <PackageReference Include="Newtonsoft.Json" Version="11.0.2" />
+    <PackageReference Include="Npgsql" Version="4.1.0-ci.1131" />


now when npgsql https://www.nuget.org/packages/Npgsql/4.0.2 with jsonb fix is released is this pre-release package necessary ?

I think so, but I'll double check that

@jacobpovar You're right 4.0.2 is enough.

jeremydmiller · 2018-07-17T15:30:10Z

src/Marten/Linq/CollectionAnyContainmentWhereFragment.cs

@@ -161,7 +154,17 @@ private string buildSubQuery(SubQueryExpression subQuery, CommandBuilder command
            {
                throwNotSupportedContains();
            }
-            var fromParam = command.AddParameter(from.Value);
+
+            var values = new List<string>();


Why are we having to do this? Is this something that got broken by npgsql 4?

It seems so, we're passing the parameter as array of text (see here ). I believe that previously it was the automated conversion of parameter, but right now it's not being performed. It throws exception that TextHandler cannot handle array of guids (or something like that). In general it's because Array of String != Array of Guids.

jeremydmiller · 2018-07-17T15:31:18Z

src/Marten/Linq/QueryHandlers/CachedQueryHandler.cs

        public void ConfigureCommand(CommandBuilder builder)
        {
            var sql = _template.CommandText;
            for (var i = 0; i < _setters.Length && i < _template.Parameters.Count; i++)
            {
                var param = _setters[i].AddParameter(_model, builder);
+
+                if (param.Value is Enum)


Why is this here? Marten has configurable enum storage of either "as strings" or "as int". This would possibly break here.

Yup, it's ugly hack. Without this casting it will throw that it doesn't know the Enum type. I need to revisit that but I believe that here it's only for querying and there would be some automated translation. I need to check it again if there is a chance to do it better.

jeremydmiller · 2018-07-17T15:31:37Z

src/Marten/Schema/BulkLoading/BulkLoader.cs

@@ -121,6 +121,8 @@ private void load(ITenant tenant, ISerializer serializer, NpgsqlConnection conn,
                    _transferData(document, _mapping.AliasFor(document.GetType()), serializer, writer, textWriter, tenant.TenantId);
                    textWriter.Clear();
                }
+
+                writer.Complete();


This is new in npgsql4?

I believe so. @jacobpovar ?

Correct.

From npgsql 4 breaking changes:

You must now call NpgsqlBinaryImporter.Complete() to save your imported data; not doing so will roll the operation back.

jeremydmiller · 2018-07-17T15:32:14Z

src/Marten/Schema/DuplicatedField.cs

@@ -38,9 +37,19 @@ public DuplicatedField(EnumStorage enumStorage, MemberInfo[] memberPath) : base(
                PgType = "varchar";
            }
            else if (MemberType.IsDateTime())
+            {


Are all the Datetime/DatetimeOffset query tests passing?

Yes. They changed a lot in the DateTime handling (see links that I attached in the PR description). Without that and other changes it won't work.

jeremydmiller · 2018-07-17T15:33:38Z

src/Marten/Services/SprocCall.cs

@@ -90,6 +88,9 @@ public SprocCall JsonBodies(string argName, ArraySegment<char>[] bodies)

        public SprocCall Param(string argName, object value, NpgsqlDbType dbType)
        {
+            if ((value is Enum || value is Guid) && dbType == NpgsqlDbType.Varchar)


Same thing here about the enum configuration on the serializer

Here it's the same case as I described with Array of Guids. It seems that there is no more automatic conversion here. They provided some changes to automatically selecting the handlers, but I don't know precisely, because it's a lack of documentation.

jeremydmiller · 2018-07-19T20:16:43Z

Hey everyone, this is now in the official "3.0" branch.

oskardudycz · 2018-07-19T20:30:49Z

🎉 🎉 🎉

jacobpovar · 2018-07-20T06:06:07Z

awesome!

david-driscoll and others added 18 commits July 14, 2018 19:25

started work on upgrade to npgsql-2.0

6ccfb19

WIP update to npgsql 4

48bf86f

Finished upgrade to npgsql4

40ab8da

Used stable version of npgsql

eb4d845

Removed leftover

6cf339e

Updated to prerelease version of npgsql

c0d3430

Fixed enum as string handling

043b1de

Added NuGet.Config

1be6f4a

Fixed NuGet.Config

3408ee9

Fixed DateTime serialization in parameters

7c558f4

Removed obsolete TimestamTZ

6c4b324

Try to fix failing date utc tests

c710e06

Next try to fix datetime test failure

5e6de74

Reverted wrong fix

83a5d81

Next try to fix datetime issues

c34c28a

Updated datetime handling

c7f5a30

Fixed DuplicatedField

2cee4ca

Fixed last failing test

c57fd08

jacobpovar reviewed Jul 16, 2018

View reviewed changes

oskardudycz added 2 commits July 16, 2018 09:43

Updated npgsql to stable version

6026418

Removed not needed NuGet.Config

e56226f

jeremydmiller reviewed Jul 17, 2018

View reviewed changes

jeremydmiller added this to the 3.0 Alpha 1 milestone Jul 19, 2018

jeremydmiller added a commit that referenced this pull request Jul 19, 2018

merged in GH-1045

2d597e5

Removed duplicated if

e30519e

jeremydmiller closed this Jul 19, 2018

oskardudycz mentioned this pull request Sep 18, 2018

Marten 3.0 improvements #1091

Merged

oskardudycz mentioned this pull request Oct 1, 2018

Make GlobalTypeMapper method ToNpgsqlDbType public npgsql/npgsql#2176

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wip update to Npgsql 4.0 #1045

Wip update to Npgsql 4.0 #1045

oskardudycz commented Jul 14, 2018 •

edited

Loading

jacobpovar Jul 16, 2018

oskardudycz Jul 16, 2018

oskardudycz Jul 16, 2018

jacobpovar Jul 16, 2018

jeremydmiller Jul 17, 2018

oskardudycz Jul 17, 2018

jeremydmiller Jul 17, 2018

oskardudycz Jul 17, 2018

jeremydmiller Jul 17, 2018

oskardudycz Jul 17, 2018

jacobpovar Jul 17, 2018

jeremydmiller Jul 17, 2018

oskardudycz Jul 17, 2018 •

edited

Loading

jeremydmiller Jul 17, 2018

oskardudycz Jul 17, 2018

jeremydmiller commented Jul 19, 2018

oskardudycz commented Jul 19, 2018

jacobpovar commented Jul 20, 2018

Wip update to Npgsql 4.0 #1045

Wip update to Npgsql 4.0 #1045

Conversation

oskardudycz commented Jul 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oskardudycz Jul 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeremydmiller commented Jul 19, 2018

oskardudycz commented Jul 19, 2018

jacobpovar commented Jul 20, 2018

oskardudycz commented Jul 14, 2018 •

edited

Loading

oskardudycz Jul 17, 2018 •

edited

Loading