-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored external library for AndroidX by creating the library internally #262
Open
mohammadnajmuzzaman
wants to merge
30
commits into
Jasonette:master
Choose a base branch
from
mohammadnajmuzzaman:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the quick start guide with Android Studio v3.2.1 yielded an error similar to what users have described here: https://stackoverflow.com/questions/52945041/couldnt-locate-lint-gradle-api-26-1-2-jar-for-flutter-project Changing the order of jcenter() to load after maven seems to fix this issue.
Fix build.gradle for Android Studio v3.2.1
Changed from `QR_CODE` to `ALL_FORMATS` as suggested by `Mike Metcalfe`. https://developers.google.com/android/reference/com/google/android/gms/vision/barcode/Barcode.html#ALL_FORMATS With this addition now the android app can scan any barcode supported by the vision engine.
Pull Request 3
…into master. It also needs a modification into AndroidManifest to work properly 'configChanges="orientation|screenSize"' in application section
AndroidX implemented. Glide Image caching updated to the AUTOMATIC strategy available in Glide 4.x Stetho added for Chrome Debugging Solved issue of app not working properly in Android Debugger. Signed-off-by: Mohammad Najmuzzaman <[email protected]>
@panterozo please check this. thanks |
Latest changes on main fork
@mohammadnajmuzzaman thanks for this pr. But this repo is no longer maintained. Please do a PR in the official Jasonelle/Jasonette-android repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed AndroidX compatibility of yqritc DividerDecoration libraries by creating them under Lib and refactoring them for AndroidX. This is over the previous pull request and takes care of all AndroidX issues.