Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CMS post summary UI #268

Merged
merged 8 commits into from
May 25, 2021

Conversation

ryon
Copy link
Member

@ryon ryon commented May 11, 2021

See SlateFoundation/slate#235 (comment)

CMS editor improvements

  • Move post summary from override to main app
  • Add toolbar button to toggle post summary (default off)
  • Show blog post summaries by default in skeleton
  • Improve some CMS editor emptyText
  • Discourage empty posts in CMS editor
    • Include a Markdown content item by default
    • Cull empty Markdown composers when saving
    • Warn if post being saved has no content blocks

Minor skeleton upgrades

  • Use a system font stack instead of Helvetica
  • Include a placeholder logo instead of linking out

@themightychris
Copy link
Member

@ryon you probably want to use the beforetoggle and toggle events rather than click events: https://docs.sencha.com/extjs/6.2.0/classic/Ext.button.Button.html#event-beforetoggle

@ryon
Copy link
Member Author

ryon commented May 11, 2021

@ryon you probably want to use the beforetoggle and toggle events

@themightychris I’m using toggle, which menucheckitem doesn’t have, for whatever reason

@themightychris themightychris merged commit cd2f9cf into develop May 25, 2021
@themightychris themightychris deleted the features/improve-cms-post-summary-ui branch May 25, 2021 19:18
@themightychris themightychris mentioned this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants