Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that works even if the path has spaces in the directory name #4167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Veera-began
Copy link


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • [ Yes] Is there an issue associated with this PR? Is it referenced in the commit message?
  • [ Yes] Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • [ Yes] Has your PR been rebased against the latest commit within the target branch (typically master)?
  • [ Yes] Is your initial contribution a single, squashed commit?

For code changes:

  • [ No] Have you written and/or updated unit tests to verify your changes?
  • [ No] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • [ No] Have you ensured that format looks appropriate for the output in which it is rendered?

FIxes: #2251

Copy link

linux-foundation-easycla bot commented Dec 3, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Dec 4, 2023
Copy link
Member

@li-boxuan li-boxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! Looks like DCO bot is failing - please sign your commit as requested by it: https://github.com/JanusGraph/janusgraph/pull/4167/checks?check_run_id=19258229114

@FlorianHockmann
Copy link
Member

Hey @Veera-began, it would be great if you could update your commit to include the necessary "Signed-off-by". All you have to do are basically these 2 steps from the link @li-boxuan posted:

In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin fixbranch

Otherwise, we unfortunately cannot accept your PR.

@li-boxuan
Copy link
Member

@Veera-began would you be able to sign-off your commit as requested by the bot? Otherwise, we may have to close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: external Externally-managed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.bat and .sh Execution Fail When Run From a Path That Contains Spaces
4 participants