Allow removal of configuration properties #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdegroc
force-pushed
the
removable-configuration
branch
from
6a0ac20 to
5ad8099
Compare
9 tasks
cdegroc
commented
Oct 17, 2023
Comment on lines
-250
to
+261
| map.put("storage.hostname", "localhost,localhost"); | ||
| map.put(STORAGE_HOSTS.toStringWithoutRoot(), "localhost,localhost"); | ||
| ConfiguredGraphFactory.updateConfiguration(graphName, new MapConfiguration(map)); | ||
| assertNull(gm.getGraph(graphName)); | ||
| assertNotNull(ConfiguredGraphFactory.open(graphName)); | ||
|
|
||
| // bogus backend will prevent the graph from being opened | ||
| final Map<String, Object> map2 = graphConfig.getMap(); | ||
| map2.put("storage.backend", "bogusBackend"); | ||
| map2.put(STORAGE_BACKEND.toStringWithoutRoot(), "bogusBackend"); |
There was a problem hiding this comment.
📝 drive-by change to reuse constants
cdegroc
commented
Oct 17, 2023
Comment on lines
-317
to
+331
| public static Map<String, Object> getConfiguration(final String configName) { | ||
| public static Map<String, Object> getConfiguration(final String graphName) { | ||
| final ConfigurationManagementGraph configManagementGraph = getConfigGraphManagementInstance(); | ||
| return configManagementGraph.getConfiguration(configName); | ||
| return configManagementGraph.getConfiguration(graphName); |
There was a problem hiding this comment.
📝 drive-by change: documentation mentioned graphName but variable was called configName.
porunov
approved these changes
Oct 17, 2023
...graph-core/src/main/java/org/janusgraph/graphdb/management/ConfigurationManagementGraph.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Clement de Groc <[email protected]>
cdegroc
force-pushed
the
removable-configuration
branch
from
5ad8099 to
95aefc1
Compare
porunov
approved these changes
Oct 18, 2023
|
I've deployed this code and tried to update an existing graph configuration. I could remove one or more configuration keys. Both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add a
removemethod to remove configuration keys:ConfiguredGraphFactory/ConfigurationManagementGraphfor ConfiguredGraphFactory configuration.JanusGraphConfiguration/UserModifiableConfiguration/ManagementSystemfor "global" configuration.Fixes #555
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master)?For code changes:
For documentation related changes: