-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add trivy scan to docker #4056
add trivy scan to docker #4056
Conversation
eedceeb
to
e85836b
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
@porunov This adds the last missing part from the janusgraph-docker repo. |
aa32268
to
cafa13d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @farodin91 !
cafa13d
to
af51c99
Compare
@farodin91 looks like it fails with |
af51c99
to
4f42219
Compare
@porunov Thank you. It should be fixed now. |
Still the same error. Do you know if this PR is a blocker for the release? |
It's a release blocker. |
4f42219
to
9d896cc
Compare
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
9d896cc
to
012cfce
Compare
@farodin91 Looks like all the tests passed. However, the required job in JanusGraph settings is set for |
Disabled |
@porunov Thank you for merging. |
Thank you for the Docker integration! |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master
)?For code changes:
For documentation related changes: