Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis integration #3018 #3100

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

washerath
Copy link

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 24, 2022

CLA Missing ID CLA Not Signed

@janusgraph-bot
Copy link

Please verify the committer name, email, and GitHub username association are all correct and match CLA records.

@janusgraph-bot janusgraph-bot added the cla: no This PR is not compliant with the CLA label Jun 24, 2022
@li-boxuan
Copy link
Member

@washerath Thank you for your contribution! A few things to notice:

  1. EasyCLA is failing because you need to sign a CLA under Linux Foundation. The bot is complaining that it cannot find your user id, so that it cannot direct you to the CLA sign page. In order to fix this, you need to make sure you do your git commits using your GitHub account. Otherwise, GitHub cannot link your commit to your account. Then the bot should be able to proceed and guide you to sign your CLA. See this for more details.
  2. You also need to "sign" your commit by appending a sign-off message at the end of each commit. You can take a look at any other commit in the repository. You can also follow this guide.
  3. For every new file, you need to add a Copyright header otherwise the CI won't proceed with the build. Take a look at any existing file in the repository.
  4. I remember you mentioned that you had to solve some performance issues. Do you have any statistics/benchmarks regarding the current performance with your Redis integration?

@janusgraph-bot
Copy link

Please verify the committer name, email, and GitHub username association are all correct and match CLA records.

@li-boxuan
Copy link
Member

@washerath Just checking if you would like to proceed with this PR. Any help needed?

@washerath
Copy link
Author

@li-boxuan Yes, I would like to contribute. As I see some checks have failed on my commit. I'll try to resolve them and try again.

@washerath washerath force-pushed the feature/redis-integration branch from 3928758 to 50d63d4 Compare December 8, 2023 04:10
…/janusgraph into feature/redis-integration

Signed-off-by: Wasantha Herath <[email protected]>
Signed-off-by: Wasantha Herath <[email protected]>
@washerath washerath force-pushed the feature/redis-integration branch from 50d63d4 to 5b224c4 Compare December 8, 2023 04:26
@janusgraph-bot janusgraph-bot added cla: external Externally-managed CLA and removed cla: no This PR is not compliant with the CLA labels Dec 15, 2023
@FlorianHockmann
Copy link
Member

@washerath Is it correct that this PR is still open or was it superseded by your new PR: #4180? Because in that case, we could close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: external Externally-managed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants