Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change night-owl to use the inverse powerline arrow head characters. #6033

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

HypheX
Copy link

@HypheX HypheX commented Dec 18, 2024

Prerequisites

  • I have read and understood the contributing guide.
  • The commit message follows the conventional commits guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features).

Description

Change the night-owl theme to use U+E0D6 and U+E0D7 for the powerline arrow heads added in ryanoasis/nerd-fonts#1490

Before:

image
image

After:

image
image

@HypheX HypheX changed the title Change night-owl to use the inverted ANSI diamonds. Change night-owl to use the inverse powerline arrow head characters. Dec 18, 2024
@HypheX HypheX marked this pull request as ready for review December 18, 2024 10:28
@HypheX
Copy link
Author

HypheX commented Dec 18, 2024

Let me know if I should bump the version field from 3 to 4.

@HypheX HypheX changed the title Change night-owl to use the inverse powerline arrow head characters. chore: Change night-owl to use the inverse powerline arrow head characters. Dec 18, 2024
@LuminarLeaf
Copy link

Let me know if I should bump the version field from 3 to 4.

No, that version is for the config file syntax schema version, version 4 doesn't even exist yet

@JanDeDobbeleer JanDeDobbeleer changed the base branch from main to beta December 22, 2024 19:36
@JanDeDobbeleer JanDeDobbeleer merged commit b694069 into JanDeDobbeleer:beta Dec 22, 2024
10 checks passed
@JanDeDobbeleer
Copy link
Owner

@all-contributors please add @HypheX for design

This is pure magic 🪄! @holopin-bot @HypheX wizard

Copy link

holopin-bot bot commented Dec 22, 2024

Congratulations @HypheX, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm500fcuk93080cmgsu827yaz

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Copy link
Contributor

@JanDeDobbeleer

I've put up a pull request to add @HypheX! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants