Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds JSON API segment #5842

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mwiedemeyer
Copy link

Prerequisites

  • I have read and understood the [contributing guide][CONTRIBUTING.md].
  • The commit message follows the [conventional commits][cc] guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features).

Description

This PR adds a segment for calling any JSON API and displays a json property from the response.
As I have no real experience with go I hope this is ok and valuable for the ecosystem.

This segment can also be updated in the future with more features like authentication, etc.

@JanDeDobbeleer
Copy link
Owner

@mwiedemeyer I want to make this a little bit more generic. I would name it http rather that jsonapi, that way we can execute any http call in the future and also allow to define HTTP method etc...

@mwiedemeyer
Copy link
Author

Hi, thanks, good idea. I've renamed jsonapi to http and also already added the http method as a property. However my go experience is not enough to make it even more generic and add a body, things like that.
Hope you can enhance it even further or use it as it is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants