Skip to content

Commit

Permalink
refactor: rename CheckBulkPermissionAsync to CheckBulkPermissionsAsync
Browse files Browse the repository at this point in the history
Renamed all instances of the method `CheckBulkPermissionAsync` to `CheckBulkPermissionsAsync` in both ISpiceDbClient and SpiceDbClient classes. This change improves readability and consistency across the codebase.
refactor: rename CheckBulkPermissionAsync to CheckBulkPermissionsAsync

Renamed all instances of the method `CheckBulkPermissionAsync` to `CheckBulkPermissionsAsync` in both ISpiceDbClient and SpiceDbClient classes. This change improves readability and consistency across the codebase. Also, updated the version number in SpiceDb.csproj from 1.4.6 to 1.4.7 reflecting these changes.
  • Loading branch information
tanczosm committed Apr 8, 2024
1 parent 299f06a commit 44383bc
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
7 changes: 3 additions & 4 deletions SpiceDb/ISpiceDbClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,9 @@ public interface ISpiceDbClient
Task<ZedToken?> ImportRelationshipsFromFileAsync(string filePath);
Task<ZedToken?> ImportRelationshipsAsync(string content);

// Experimental API Methods
Task<CheckBulkPermissionsResponse?> CheckBulkPermissionAsync(IEnumerable<CheckBulkPermissionsRequestItem> items, ZedToken? zedToken = null, CacheFreshness cacheFreshness = CacheFreshness.AnyFreshness);
Task<CheckBulkPermissionsResponse?> CheckBulkPermissionsAsync(IEnumerable<CheckBulkPermissionsRequestItem> items, ZedToken? zedToken = null, CacheFreshness cacheFreshness = CacheFreshness.AnyFreshness);

Task<CheckBulkPermissionsResponse?> CheckBulkPermissionAsync(IEnumerable<string> permissions, ZedToken? zedToken = null, CacheFreshness cacheFreshness = CacheFreshness.AnyFreshness);
Task<CheckBulkPermissionsResponse?> CheckBulkPermissionsAsync(IEnumerable<string> permissions, ZedToken? zedToken = null, CacheFreshness cacheFreshness = CacheFreshness.AnyFreshness);

Task<CheckBulkPermissionsResponse?> CheckBulkPermissionAsync(IEnumerable<Models.Permission> permissions, ZedToken? zedToken = null, CacheFreshness cacheFreshness = CacheFreshness.AnyFreshness);
Task<CheckBulkPermissionsResponse?> CheckBulkPermissionsAsync(IEnumerable<Models.Permission> permissions, ZedToken? zedToken = null, CacheFreshness cacheFreshness = CacheFreshness.AnyFreshness);
}
2 changes: 1 addition & 1 deletion SpiceDb/SpiceDb.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<PackageIcon>logo.png</PackageIcon>
<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
<PackageReadmeFile>README.md</PackageReadmeFile>
<Version>1.4.6</Version>
<Version>1.4.7</Version>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
Expand Down
10 changes: 5 additions & 5 deletions SpiceDb/SpiceDbClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -530,25 +530,25 @@ public async Task ImportSchemaFromStringAsync(string schema)
return (await _core.Permissions.WriteRelationshipsAsync(updateCollection)).WrittenAt.ToSpiceDbToken();
}

public async Task<CheckBulkPermissionsResponse?> CheckBulkPermissionAsync(IEnumerable<string> permissions,
public async Task<CheckBulkPermissionsResponse?> CheckBulkPermissionsAsync(IEnumerable<string> permissions,
ZedToken? zedToken = null, CacheFreshness cacheFreshness = CacheFreshness.AnyFreshness)
{
var items = permissions.Select(perm => new CheckBulkPermissionsRequestItem()
{ Permission = new Models.Permission(perm) });

return await CheckBulkPermissionAsync(items, zedToken, cacheFreshness);
return await CheckBulkPermissionsAsync(items, zedToken, cacheFreshness);
}

public async Task<CheckBulkPermissionsResponse?> CheckBulkPermissionAsync(
public async Task<CheckBulkPermissionsResponse?> CheckBulkPermissionsAsync(
IEnumerable<Models.Permission> permissions,
ZedToken? zedToken = null, CacheFreshness cacheFreshness = CacheFreshness.AnyFreshness)
{
var items = permissions.Select(perm => new CheckBulkPermissionsRequestItem() { Permission = perm });

return await CheckBulkPermissionAsync(items, zedToken, cacheFreshness);
return await CheckBulkPermissionsAsync(items, zedToken, cacheFreshness);
}

public async Task<CheckBulkPermissionsResponse?> CheckBulkPermissionAsync(
public async Task<CheckBulkPermissionsResponse?> CheckBulkPermissionsAsync(
IEnumerable<CheckBulkPermissionsRequestItem> items,
ZedToken? zedToken = null, CacheFreshness cacheFreshness = CacheFreshness.AnyFreshness)
{
Expand Down

0 comments on commit 44383bc

Please sign in to comment.