Fixing an issue with per file settings. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking into this. The |
| const model = config.get<string>("model") ?? "gpt-3.5-turbo" | ||
| const endpoint = | ||
| let model = config.get<string>("model") ?? "gpt-3.5-turbo" | ||
| let endpoint = | ||
| config.get<string>("endpoint") ?? | ||
| "https://api.openai.com/v1/chat/completions" | ||
|
|
There was a problem hiding this comment.
Maybe just
const endpoint =
notebook.metadata.parameters?.settings?.endpoint ??
config.get<string>("endpoint") ??
"https://api.openai.com/v1/chat/completions"
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in relation to #4
I noticed theer was code to get stuff from notebook.metadata.parameters and put it in the options field of OpenAI api request. I wanted a per file ability to specify endpoints (to use different models, including self hosted ones) so I added this code to handle an extra object under parametrs called settings. If it contains property of endpoint or model, it will override global config. Then settings is deleted and the rest of parameters is handled the same as before.
Hopefully it is of use to someone.