Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandon apca check #31

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Abandon apca check #31

merged 2 commits into from
Oct 16, 2024

Conversation

vincerubinetti
Copy link
Collaborator

@vincerubinetti vincerubinetti commented Oct 10, 2024

Closes #22 as wont-fix. See StackExchange/apca-check#143

  • update expand/collapse icons
  • remove apca-check as it wasn't working anyway
  • re-enable normal/current WCAG v2 (or whatever) color-contrast rule (which is very inaccurate and not very useful), and make it a warning instead of a failure

See this issue, which might cover APCA:
#33

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for molevolvr ready!

Name Link
🔨 Latest commit b31077b
🔍 Latest deploy log https://app.netlify.com/sites/molevolvr/deploys/670ea834f041720008c4eb90
😎 Deploy Preview https://deploy-preview-31--molevolvr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks reasonable. Too bad about apca-check not working and the general lack of good contrast testing in the other accessibility suites, but as you said Lighthouse could be an alternative.

@vincerubinetti vincerubinetti merged commit 046bb45 into main Oct 16, 2024
4 checks passed
@vincerubinetti vincerubinetti deleted the apca branch October 16, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement color contrast accessibility test
2 participants