Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fit button to network visualization #30

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

kemsguy7
Copy link
Contributor

@kemsguy7 kemsguy7 commented Oct 9, 2024

Closes #19

Note, originally this PR also made modifications from #23 . I've rewritten history to only include the network fit button feature, and added some related features/fixes of my (VR) own:

  • VR: update table fixture data such that including the 4th "long" column in the table on the testbed page definitely overflows the screen width, testing scroll and collapse/expand CSS
  • VR: make custom icons for expanding/collapsing table width and network viz width, since none in react-icons were quite adequate. some were close but felt not distinct enough from the new fit button icon added in this PR.
  • KG: add network visualization fit button with icon
  • VR: fix table expand/collapse css

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for molevolvr ready!

Name Link
🔨 Latest commit e08dcd9
🔍 Latest deploy log https://app.netlify.com/sites/molevolvr/deploys/6707498d8118ba00089f643e
😎 Deploy Preview https://deploy-preview-30--molevolvr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vincerubinetti vincerubinetti changed the title Network button fix Add fit button to network visualization Oct 9, 2024
@vincerubinetti vincerubinetti merged commit 62b19e0 into JRaviLab:main Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fit button to network visualization
2 participants