Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gradle File (Probably) #137

Closed
wants to merge 5 commits into from

Conversation

ithinkimcats
Copy link

Pull Request

Pull Request Checklist

Please follow the following steps before opening this PR.

PRs that do not complete the checklist will be subject to denial for
missing information.

Pull Request Information

Check and fill in the blanks for all that apply:

  • My PR fixes a bug, error, or other issue with the library's codebase.
  • My PR is for the ______ module of the JDA-Utilities library.
  • My PR creates a new module for the JDA-Utilities library: ______.

Description

Describe your PR here.

This should fix the Gradle file (maybe) but I also don't know anything about Gradle or Java so I don't know really. I also don't know how to have it "publish to dv8's host" but I have tried (?) to make it do that based on Gradle documentation. I have no idea if this works how you intended it in java cup but when I test it, it does produce the jars and the poms and it says "BUILD SUCCESSFUL", but I really do not know! Yeah.

@SplitPixl
Copy link

This Looks Like Code

@ithinkimcats
Copy link
Author

I think this should be it.

@Chew
Copy link

Chew commented Feb 12, 2022

I've suggested (and highly encouraged) in Chew#53 to just simply rewrite the damn build.gradle file (bonus: a rewrite in kotlin). This was written for an ancient version of Gradle and the entire DSL has significantly changed. This file can be heavily reduced with modern features, and I think it's time to stop dragging this dying horse to its knees. The code does work, yeah, but anyone who uses and knows (or even works for) Gradle cannot help but be abhorred by this poor file.

If you really want, though, my build.gradle does support pushing to a maven repo, in an ass-backwards way as you'd expect, given the file I've been given.

Also, if you're gonna bump the Gradle version, be sure to run gradle wrapper --gradle-version=7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants