Fix: Enter key interrupts IME composition in MessageInput component #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minai621
force-pushed
the
fix/ime-composition-issue
branch
from
53062c9
to
a169418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue in the MessageInput component where pressing the Enter key during IME (Input Method Editor) composition interrupts the composition process. Users typing in languages that require IME input, such as Korean, Chinese, or Japanese, are affected by this bug.
Problem
When users are composing text using an IME, the onKeyDown event handler does not account for the composition state. Pressing the Enter key during composition prematurely ends the process, resulting in incomplete characters or leaving residual text in the input field.
Related Issue
Closes #443
Checklist