Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update News Card Layout, Remove README Text, Add Show More/Show Less Button #272

Open
wants to merge 60 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
5b1aaee
chore: Update eslint and prettier configurations
JYC-99 Jul 5, 2024
3b737a0
prettier
JYC-99 Jul 5, 2024
81c5e30
chore: Update dependencies and fix import paths
JYC-99 Jul 5, 2024
6d6bf11
update
JYC-99 Jul 5, 2024
8f793d2
update
JYC-99 Jul 5, 2024
9bd7486
fix build issues
JYC-99 Jul 5, 2024
4d4f6f6
update
JYC-99 Jul 5, 2024
04bf883
chore: Remove unused GitHub templates and workflows
JYC-99 Jul 5, 2024
0f76f37
update
JYC-99 Jul 5, 2024
aed0a4a
update
JYC-99 Jul 5, 2024
78738c9
Merge pull request #1 from newspedia-crew/yucongj/setup
guanghechen Jul 5, 2024
effd1d3
change the npm to yarn and update the json
TomorrowMC Jul 10, 2024
ca4dfec
fix the PR gated
TomorrowMC Jul 10, 2024
bf170a0
fix the PR gated
TomorrowMC Jul 10, 2024
fc091da
fix the PR gated
TomorrowMC Jul 10, 2024
e14bb33
fix the PR gated
TomorrowMC Jul 10, 2024
10b38e3
fix the color of dark mode
TomorrowMC Jul 10, 2024
c2d76e0
fix and polish the return button
TomorrowMC Jul 10, 2024
bd230dd
Merge pull request #3 from newspedia-crew/intern-change
guanghechen Jul 10, 2024
85d144a
feat: support markdown
guanghechen Jul 10, 2024
e775b6e
improve: render description with markdown
guanghechen Jul 10, 2024
cfa6efc
fix lint
guanghechen Jul 10, 2024
94d944b
fix lint
guanghechen Jul 10, 2024
a7c72ff
fix lint
guanghechen Jul 10, 2024
b4b3d0f
Merge pull request #4 from newspedia-crew/dev-ghc
JYC-99 Jul 10, 2024
5c0a512
fix the image of provider, read more button
TomorrowMC Jul 11, 2024
14294f8
news list now can load local json file
TomorrowMC Jul 11, 2024
deb82d3
now can load local detail news
TomorrowMC Jul 11, 2024
e8e90d8
change the wrong file name
TomorrowMC Jul 12, 2024
07a6648
combine the lib/fetnewsdata.tsx to app/api/news/[id]/page.tsx
TomorrowMC Jul 12, 2024
8e918dd
delete the unused file
TomorrowMC Jul 12, 2024
7c5ab7c
delete the unused file
TomorrowMC Jul 12, 2024
4007efc
add a constant file to read the env variables
TomorrowMC Jul 12, 2024
3b2a91c
fixed the bugs
TomorrowMC Jul 12, 2024
047df7e
fix the constants
TomorrowMC Jul 12, 2024
c50197d
fix the bugs
TomorrowMC Jul 12, 2024
ffb744c
fix the port
TomorrowMC Jul 12, 2024
1ac51ee
fix the bugs
TomorrowMC Jul 12, 2024
52fd0b2
fix the constants of ENV
TomorrowMC Jul 12, 2024
ebfae3a
Merge pull request #5 from newspedia-crew/intern-change
guanghechen Jul 12, 2024
702e13b
feat: add responsive image at news root page
Keviniscaiji Jul 12, 2024
5498fc9
feat: Merge two divs into one and set responsive layout that changes …
Keviniscaiji Jul 15, 2024
460c523
feat: remove unused code
Keviniscaiji Jul 15, 2024
0590864
feat: Modify the layout of news items Add the function of expanding o…
Keviniscaiji Jul 18, 2024
93b1b18
feat: remove unused code
Keviniscaiji Jul 19, 2024
3e88692
feat: import the news details layout
Keviniscaiji Jul 19, 2024
8385b2d
feat: try to fix eslint not find problem
Keviniscaiji Jul 19, 2024
a69f3a2
feat: try to fix eslint problem
Keviniscaiji Jul 19, 2024
517b473
feat: update config files
Keviniscaiji Jul 19, 2024
5cdce15
feat: try to fix eslint problem
Keviniscaiji Jul 19, 2024
4b02b3d
feat: try to fix eslint problem
Keviniscaiji Jul 19, 2024
10ba0e1
chore: remove package-lock.json
guanghechen Jul 19, 2024
f93ab46
chore: revert dependencies changes
guanghechen Jul 19, 2024
c289271
test: only run ci on ubuntu-latest
guanghechen Jul 19, 2024
4cfb17e
test: run ci exclude windows
guanghechen Jul 19, 2024
bdae870
test: run ci exclude node22
guanghechen Jul 19, 2024
1b864d8
chore(ci): run node22.4.x to avoid eslint not found issues
guanghechen Jul 19, 2024
3014f15
feat: change the layout of newsitem
Keviniscaiji Jul 22, 2024
0c5d132
improve: remove unnecessary code
Keviniscaiji Jul 22, 2024
48c8181
feat: align the NewsDetail page style with the related contents on th…
Keviniscaiji Jul 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# editorconfig.org
root = true

[*]
charset = utf-8
indent_size = 2
indent_style = space
insert_final_newline = true
max_line_length = 120
quote_type = double
trim_trailing_whitespace = true

[*.md]
trim_trailing_whitespace = false
2 changes: 2 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
node_modules
dist
32 changes: 32 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"root": true,
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"plugin:prettier/recommended",
"plugin:unicorn/recommended"
],
"parser": "@typescript-eslint/parser",
"plugins": [
"@typescript-eslint",
"prettier",
"unicorn"
],
"rules": {
"unicorn/filename-case": [
"error",
{
"cases": {
"camelCase": true,
"pascalCase": true
}
}
],
"unicorn/prevent-abbreviations": "warn",
"unicorn/no-null": "off",
"@typescript-eslint/no-unused-vars": "off"
},
"overrides": [

]
}
1 change: 0 additions & 1 deletion .github/FUNDING.yml

This file was deleted.

27 changes: 0 additions & 27 deletions .github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

7 changes: 0 additions & 7 deletions .github/ISSUE_TEMPLATE/custom.md

This file was deleted.

19 changes: 0 additions & 19 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

39 changes: 39 additions & 0 deletions .github/workflows/pr-gated.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: PR-gated

on:
pull_request:
branches: [main]
types: [opened, synchronize, reopened, ready_for_review]

workflow_dispatch:

jobs:
build:
if: github.event.pull_request.draft == false
name: Test on node ${{ matrix.node_version }} and ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
node_version:
- 20.x
- 22.4.x
os: [ubuntu-latest, windows-latest, macOS-latest]

steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node_version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node_version }}
- name: yarn install
run: yarn --frozen-lockfile
- name: lint
run: yarn lint
- name: build
run: yarn build
- name: yarn install:ui
run: yarn --frozen-lockfine
working-directory: ./ui
- name: build:ui
run: yarn build
working-directory: ./ui
5 changes: 0 additions & 5 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@ yarn-error.log
/out/
/dist/

# IDE/Editor specific
.vscode/
.idea/
*.iml

# Environment variables
.env
.env.local
Expand Down
5 changes: 5 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"endOfLine": "auto",
"trailingComma": "all",
"arrowParens": "avoid"
}
14 changes: 14 additions & 0 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"recommendations": [
"dbaeumer.vscode-eslint",
"streetsidesoftware.code-spell-checker",
"github.codespaces",
"github.copilot",
"github.copilot-chat",
"github.vscode-pull-request-github",
"eamodio.gitlens",
"vincaslt.highlight-matching-tag",
"orta.vscode-jest",
"esbenp.prettier-vscode"
]
}
Loading