Improve build further #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous slowness I'd seen during the Setup .NET step wasn't the download, which was only 5 or 6 seconds, but the .zip extraction. According to what I've read since then, hosted Windows runners for now have an issue with the C: drive being slower than D:, and the suggestion was to install in the faster location as a quick fix. Let's see how that works out.
Merge is the first word of this message as a test. Checking for [skip benchmarks] first (yes I just typed it, that's another test) avoids the rare, but still possible, situation of a merge commit in a PR that's not one of Github's invisible ones after a force push. If the text is there, it's important, so obey it. Checking for 'Merge' afterwards ultimately gets the same result as checking beforehand. This commit also gets rid of one unnecessary variable and hoists another out of the loop. Vanishingly minor imperfections, but they still bugged me.
As per ItEndsWithTens/Arbatel@fead830 this was using the style of .csproj tags necessary for analyzers in the .NET 6 preview SDK. We're well past that now, so the new style should be perfectly appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.