Add Settings tab

README.md

@@ -7,8 +7,6 @@
 
   This is currently implemented as a [BizHawk](https://github.com/TASVideos/BizHawk) external tool; also included are the beginnings of a standalone GUI app based on [Eto.Forms](https://github.com/picoe/Eto) and [Eto.Veldrid](https://github.com/picoe/Eto.Veldrid), but that's a long way off, if it ever happens. For now the external tool is a useful, if scatterbrained, testbed for various ideas.
 
-  Downloads are available through the badges above, or on the releases page. Just unzip into your BizHawk/ExternalTools directory and enjoy! If instead you'd like to build it yourself, read on.
-
 
 
   ## Requirements
@@ -18,6 +16,12 @@
 
 
 
+  ## Installation
+
+  Downloads are available through the badges above, or on [the releases page](https://github.com/ItEndsWithTens/SilentHillMapExaminer/releases). Just unzip into your BizHawk/ExternalTools directory and enjoy!
+
+
+
   ## Usage
 
   TODO: Proper docs for the other tabs.

src/SHME.ExternalTool.Extras/Settings.cs

@@ -45,6 +45,8 @@ public Settings(string company, string product, string component)
 				.LoadNow()
 				.EnableAutosave();
 
+			bool save = false;
+
 			// Settings that are collections need to be initialized as empty
 			// first, then populated later. Otherwise JsonSettings creates a
 			// series of duplicate entries in your settings file on every load.
@@ -61,6 +63,8 @@ public Settings(string company, string product, string component)
 						Local.FpsBinds.Add(new InputBind(d));
 					}
 				}
+
+				save = true;
 			}
 
 			if (Local.FlyBinds?.Count < DefaultLocalSettings.FlyBinds.Count)
@@ -76,6 +80,19 @@ public Settings(string company, string product, string component)
 						Local.FlyBinds.Add(new InputBind(d));
 					}
 				}
+
+				save = true;
+			}
+
+			// JsonSettings can't autosave changes to collections that don't
+			// implement INotifyCollectionChanged, but even for such collection
+			// types there are no change events raised when elements of the
+			// collection have changed, only when the collection itself has
+			// changed. Developing a custom collection class with that feature
+			// is much more involved than just calling Save when necessary.
+			if (save)
+			{
+				Local.Save();
 			}
 
 			Roaming = JsonSettings

src/SHME.ExternalTool/UI/CustomMainForm.cs

@@ -393,6 +393,9 @@ private void LoadSettings()
 			Settings = new Settings("com.gyroshot", ToolName, component);
 
 			InitializeDataBindings();
+
+			TbxSettingsFilesLocal.Text = Settings.Local.FileName;
+			TbxSettingsFilesRoaming.Text = Settings.Roaming.FileName;
 		}
 
 		private List<((Vertex a, Vertex b), Color color, bool visible)> ScreenSpaceLines { get; } = [];
@@ -836,7 +839,9 @@ private void InitializeOverlay()
 
 			_dummyViewport = new Viewport(0, 0, RenderPort.Width, RenderPort.Height);
 
-			CleanUpDisposables();
+			Pen?.Dispose();
+			Reticle?.Dispose();
+			Overlay?.Dispose();
 
 			Pen = new Pen(Brushes.White);
 			Reticle = GenerateReticle(Pen, RenderPort.Width, RenderPort.Height, (float)NudCrosshairLength.Value);