Skip to content

Commit

Permalink
Stop grabbing the framebuffer on tool load
Browse files Browse the repository at this point in the history
  • Loading branch information
ItEndsWithTens committed Jun 14, 2024
1 parent add16e3 commit db0f648
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/SHME.ExternalTool/UI/CustomMainForm.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions src/SHME.ExternalTool/UI/Events.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ private void AttachEventHandlers()

StageLoaded += UpdateArrays;
StageLoaded += LoadHarryModel;

// It's unseemly to have the framebuffer picture box populated
// with an image on first loading the tool, so don't attach the
// ValueChanged handler until after settings are bound.
NudFramebufferOfsX.ValueChanged += NudFramebuffer_ValueChanged;
NudFramebufferOfsY.ValueChanged += NudFramebuffer_ValueChanged;
NudFramebufferW.ValueChanged += NudFramebuffer_ValueChanged;
NudFramebufferH.ValueChanged += NudFramebuffer_ValueChanged;
}
private void DetachEventHandlers()
{
Expand All @@ -56,6 +64,11 @@ private void DetachEventHandlers()

StageLoaded -= UpdateArrays;
StageLoaded -= LoadHarryModel;

NudFramebufferOfsX.ValueChanged -= NudFramebuffer_ValueChanged;
NudFramebufferOfsY.ValueChanged -= NudFramebuffer_ValueChanged;
NudFramebufferW.ValueChanged -= NudFramebuffer_ValueChanged;
NudFramebufferH.ValueChanged -= NudFramebuffer_ValueChanged;
}

private void OnStageLoaded(object sender, EventArgs e)
Expand Down
1 change: 1 addition & 0 deletions src/SHME.ExternalTool/UI/FramebufferTab.cs
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ private void BtnFramebufferGrab_Click(object sender, EventArgs e)

bmp.UnlockBits(data);

BpbFramebuffer.Image?.Dispose();
BpbFramebuffer.Image = bmp;

_framebufferGrabOriginalW = width;
Expand Down

0 comments on commit db0f648

Please sign in to comment.