Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind subgraph newAbortController event to parent graph #463

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

ZhangYiJiang
Copy link
Contributor

Using --trace-warnings I think the warning is still happening because of subgraphs - the event is only bound in createProcessor, but the trace shows the call stack going through SubGraphNodeImpl and createSubProcessor does not bind this event so the controllers aren't passed back up.

@ZhangYiJiang ZhangYiJiang marked this pull request as ready for review December 23, 2024 18:24
@abrenneke
Copy link
Collaborator

So, I'm really not sure if this was intentional or not :/

@ZhangYiJiang
Copy link
Contributor Author

Pretty sure it's not intended since this means the original code that tried to suppress the event emitter warnings just didn't work if you used any subgraphs.

The original code had to pass the controller through events because the controllers were created in iso code and could not call setMaxListeners since that's a Node API (there is nodejs/node#54758 but it was not adopted), it's not really a meaningful event, it's just a workaround to allow rivet-core to remain isomorphic

@abrenneke
Copy link
Collaborator

Oh right, yeah!

@abrenneke abrenneke merged commit c507a75 into main Jan 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants