Switch from cryptonite to crypton #6575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should not be merged until the two SRPs added in this PR are removed. |
erikd
commented
Oct 16, 2024
| @@ -478,7 +478,7 @@ library marlowe-internal | |||
| build-depends: | |||
| , base | |||
| , bytestring | |||
| , cardano-crypto-class >=2.1.5 && <2.3 | |||
| , cardano-crypto-class | |||
There was a problem hiding this comment.
This constraint here seems superfluous.
erikd
commented
Oct 16, 2024
| @@ -291,12 +291,12 @@ library | |||
| , bytestring | |||
| , bytestring-strict-builder | |||
| , cardano-crypto | |||
| , cardano-crypto-class ^>=2.1.5 | |||
| , cardano-crypto-class ^>=2.2 | |||
There was a problem hiding this comment.
Latest master version of cardano-base
erikd
changed the title
|
This can be merged because this |
The former is deprecated in favor of the latter which is is drop in replacement. This change also requires a bump in the major version of `cardano-crypto-class` and related packages from `2.1.*` to `2.2.*`. No changes are required in Plutus for this change, but `cardano-ledger` does not currently support `2.2.*`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former is deprecated in favor of the latter which is is drop in replacement. This change also requires a bump in the major version of
cardano-crypto-classand related packages from2.1.*to2.2.*. No changes are required in Plutus for this change, butcardano-ledgerdoes not currently support2.2.*.Pre-submit checklist: