More granular micro-benchmark for the IO part of lookups #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheinzel
approved these changes
May 16, 2024
| , bench "Batched lookups in IO" $ | ||
| nfAppIO (\ks' -> lookupsInBatches hasBlockIO bsize resolveV rs blooms indexes kopsFiles ks') ks | ||
| whnfAppIO (\ks' -> lookupsInBatches hasBlockIO bsize resolveV rs blooms indexes kopsFiles ks') ks |
There was a problem hiding this comment.
Did this make a noticeable difference?
There was a problem hiding this comment.
The difference is not very noticeable, or at least small enough that I can't say for certain whether there is a significant difference. We're talking about a ~10 micro-seconds difference in the positive lookup scenario, and no real difference in the negative lookup scenario
There was a problem hiding this comment.
Conceptually whnfAppIO is the right thing to do: the data should already be fully evaluated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tackles the same thing as #212, but only for the lookup micro-benchmarks.