Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hackage.nix #180

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Update hackage.nix #180

merged 3 commits into from
Mar 28, 2023

Conversation

michaelpj
Copy link
Contributor

No description provided.

@michaelpj michaelpj requested a review from a team as a code owner March 28, 2023 09:20
@jasagredo
Copy link
Contributor

What is the difference between consensus 0.3.0.0 and the revision you publish in this PR?

@michaelpj
Copy link
Contributor Author

I'll tell you once I'm done :) basically I'm adding bounds on unix-bytestring like @coot did in https://github.com/input-output-hk/cardano-haskell-packages/pull/177

@michaelpj
Copy link
Contributor Author

Also I said in the commit message. Really we need input-output-hk/foliage#42 to make this sort of thing actually reviewable!

@michaelpj
Copy link
Contributor Author

I had to revise all the ouroboros-consensus package versions in the end, cabal is very keen to pick a newer unix-bytestring 😆

@michaelpj
Copy link
Contributor Author

cc @input-output-hk/ouroboros-consensus

Hard to review I know.

@michaelpj
Copy link
Contributor Author

(In case it wasn't clear, this should be ready to go)

Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that all the revisions do basically this change:

-342                      , unix-bytestring
+342                      , unix-bytestring < 0.4

So this looks good, thank you @michaelpj

@michaelpj michaelpj merged commit 5ce31e2 into main Mar 28, 2023
@michaelpj michaelpj deleted the mpj/bump-hackage branch March 28, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants