Fix for toolchain flags.

[jubeira]

See #79 (comment).

[meyerj]

Seems to work. At least the -g flag disappeared again from compiler command lines.

For the RelWithDebInfo build I am not sure about the exact order or whether the remainder of the file is required at all. I think it can be completely removed. If not, CMAKE_*_FLAGS_RELWITHDEBINFO is cached below, after copying the values of CMAKE_*_FLAGS_RELEASE. So in theory it should contain ANDROID_COMPILER_FLAGS_RELEASE then and the last three lines will add ANDROID_COMPILER_FLAGS_RELWITHDEBINFO again.

Line 20 is not necessary because ANDROID_COMPILER_FLAGS_RELWITHDEBINFO copied from ANDROID_COMPILER_FLAGS_RELEASE has already been converted to a space-separated string in the included toolchain file.

[jubeira]

I just submitted the changes; PTAL @meyerj

[meyerj]

The last three lines could have been removed, too, but it also does not matter:

if(ANDROID_TOOLCHAIN STREQUAL clang)
  list(APPEND ANDROID_COMPILER_FLAGS_RELWITHDEBINFO -fno-limit-debug-info)
endif()

ANDROID_COMPILER_FLAGS_RELWITHDEBINFO is not used directly afaik. At the moment CMAKE_*_FLAGS_RELWITHDEBINFO are the same as CMAKE_*_FLAGS_RELEASE with -g preprended, and only those will be forwarded to the compiler. So -fno-limit-debug-info would not be set for RelWithDebInfo. Not sure whether it would be required.