This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Docker2 #121
Open
Docker2 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgururaj
reviewed
Jun 27, 2017
| * CMAKE_BUILD_TYPE=Release | ||
| * DO_PROFILING=False | ||
| * DISABLE_OPENMP=True | ||
| * BUILD_JAVA=False |
There was a problem hiding this comment.
Why disable OpenMP and Java?
kdatta
suggested changes
Jun 27, 2017
| @@ -0,0 +1,99 @@ | |||
| #! /bin/bash | |||
| # The MIT License (MIT) | |||
| # Copyright (c) 2017 Intel Corporation | |||
|
|
||
| FROM centos:7 | ||
|
|
||
| LABEL vendor="Intel Inc." name="GenomicsDB Builder" version="1.0" description="Build GenomicsDB" |
|
|
||
| # make protobuf | ||
| build_proto_buf() { | ||
| echo "+++ Building protobuf at ${PROTOBUF_LIBRARY}..." |
There was a problem hiding this comment.
the message is wrong. you're not building protobuf under $BUILD_ROOT/protobuf_build, you're building it under /output
There was a problem hiding this comment.
you did not use PROTOBUF_LIBRARY actually in the cmake
| @@ -1,5 +1,5 @@ | |||
| # The MIT License (MIT) | |||
| # Copyright (c) 2016-2017 Intel Corporation | |||
| # Copyright (c) 2017 Intel Corporation | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker source code for building genomicsDB executables.