Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Listening to", multiple artists, and artist image #37

Merged
merged 5 commits into from
Jul 29, 2024
Merged

"Listening to", multiple artists, and artist image #37

merged 5 commits into from
Jul 29, 2024

Conversation

n1ckoates
Copy link
Collaborator

@n1ckoates n1ckoates commented Jul 26, 2024

Discord just added support for the "Listening" activity type, so I switched to that.

Also added support for multiple artists, and added an option (enabled by default) to show the artist's picture as a small image. Tweaked formatting a bit to better suit how Discord displays it.

image

discord-rpc doesn't support activity types yet, so this pull request depends on discordjs/RPC#149.

You can patch discord-rpc to get this working right now: add another line below line 520 of node_modules/discord-rpc/src/client.js, with the contents

type: 2,

@Inrixia
Copy link
Owner

Inrixia commented Jul 26, 2024

Waiting on client library support then will merge this once the //@ts-expect-error has been updated etc

@n1ckoates n1ckoates changed the title Use "Listening to" activity + support for multiple artists "Listening to", multiple artists, and artist image Jul 26, 2024
@Inrixia Inrixia merged commit b48f45a into Inrixia:master Jul 29, 2024
@Inrixia
Copy link
Owner

Inrixia commented Jul 29, 2024

This is awesome, thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants