Iron - v2.0.0 release #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DebitCardz
requested changes
Sep 27, 2024
gradle/libs.versions.toml
Outdated
Comment on lines
25
to
27
| test-sqlite = { module = "org.xerial:sqlite-jdbc", version.ref = "sqlite" } | ||
| test-log4j = { module = "org.apache.logging.log4j:log4j-core", version.ref = "log4j" } | ||
| test-log4j-impl = { module = "org.apache.logging.log4j:log4j-slf4j2-impl", version.ref = "log4j" } | ||
| test-h2 = { module = "com.h2database:h2", version.ref = "h2" } | ||
| test-logback = { module = "ch.qos.logback:logback-classic", version.ref = "logback" } |
There was a problem hiding this comment.
why're we prefixing with test-, just let it be h2, logback etc. and we import as a test impl in our gradle.
There was a problem hiding this comment.
This is to prevent accidental usage of these dependencies in non-test environments by providing them a label
DebitCardz
requested changes
Sep 27, 2024
src/main/kotlin/gg/ingot/iron/transformer/adapter/ValueAdapter.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/ingot/iron/transformer/models/ConstructorDetails.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/ingot/iron/transformer/adapter/BooleanValueAdapter.kt
Outdated
Show resolved
Hide resolved
This reverts commit 89af469.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will overview everything happening in the 2.0 release of Iron. Major changes include:
This pull request introduces breaking changes.