Fixed edge case that might lead to Serial beeing stuck in spinlook wait #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
The if condition to store data in the buffer is triggered regardless of the current uart transmit status if tail and head differ:
This can lead to an infinte loop in the spinlook if the transmit IRQ is executed in the wrong moment and not new transmission is started. To prevent this a check is added to ensure that a new transmission is started if non is currently in progress by the following code:
This seems to fix the problem on my setup.
Context
Tested on a XMC4700 Relax Kit using the 3.4.1 Version of the XMC for Arduino Core running 2Mbit Serial1 to a TLE9012 and a 115200 Bit/s Serial to the Host PC