feat: added repolinter github action #76
Conversation
|
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Tip Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example... Powered by DryRun Security |
| "rule": { | ||
| "type": "file-not-exists", | ||
| "options": { | ||
| "globsAll": [ | ||
| ".secrets.baseline", | ||
| "sherpa-config.yml", | ||
| ".snyk", | ||
| "sonar-project.properties", |
There was a problem hiding this comment.
Why do you remove this condition? We need it in this step https://github.com/InditexTech/gh-sherpa/blob/main/.github/workflows/PR-verify.yml#L31.
There was a problem hiding this comment.
The condition fail if these file exists, as we are using sonar condition always fail
There was a problem hiding this comment.
Sonar is not working well because you have opened the pull request in a fork. You must open the PR in this repository for Sonar to work correctly.
| name: 'Validate master branch with Repolinter' | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
Could we eliminate the step https://github.com/InditexTech/gh-sherpa/blob/main/.github/workflows/PR-verify.yml#L37 and always run this action on push?
There was a problem hiding this comment.
If sonar runs too in another action should be possible
|
Currently, this linter is already executed in the |
added repolinter github action, requires reuse github action to work