feat(core): add option to hide existence of not-permitted commands #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 84 files ±0 84 suites ±0 13s ⏱️ ±0s Results for commit f1b833b. ± Comparison against base commit c3c3f23. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
jpenilla
force-pushed
the
convert-permission-exceptions
branch
from
b225229
to
ab9bbbf
Compare
jpenilla
force-pushed
the
convert-permission-exceptions
branch
from
ab9bbbf
to
42827d4
Compare
jpenilla
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option so that when the sender is permitted to use a following or preceding node to the one parsed, an invalid syntax exception is returned instead of no permission. Maybe this option should also convert other no permission exceptions to unknown command? Or users could do that via the exception handling system.
Should this be expanded to invalid sender exceptions as well? (probably)