Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added touch flip flags to TFT_eSPI driver. #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tpitman
Copy link
Contributor

@tpitman tpitman commented Aug 26, 2020

I don't know if this is the right way to do this, but it is the way that works for me. I am creating this pull request knowing full well that you might come up with a better way. I need the touch to be rotated independent of the screen graphics and don't see a way to do one without the other. So adding these flags lets me rotate just the touch input.

@ImpulseAdventure
Copy link
Owner

Hi Tony — in general, the calibration was supposed to take care of the display vs touch orientation so it is interesting to find a case where we need an additional flip setting. It could very well be needed!

Just so that I understand your particular device setup and rule out any calibration issues, can you confirm the following:

  • Which touch driver are you using?
  • If it was a resistive touch panel, can you attach the output of the diag_ard_touch_calib calibration sketch?

Thanks!

@tpitman
Copy link
Contributor Author

tpitman commented Aug 26, 2020 via email

@ImpulseAdventure
Copy link
Owner

Thanks Tony... yes, we might need to apply some additional options to support your particular capacitive display.

Could you run the following test for me?

  • Load examples/arduino/diag_ard_touch_calib
  • Modify (~ line 40): Comment out the #error Calibration only supported...
  • Modify (~ line 199): Change DET_RAW_RANGE_MIN to 150
  • Run the first 5 steps of the calibration (pressing on each cross-hair)
  • Please paste or attach the serial monitor output to this issue

Thanks!

@ImpulseAdventure
Copy link
Owner

Hi @tpitman — we can certainly add the ability to flip the capacitive touch orientations, much like you had proposed here.

The reason for my test request in #249 (comment) was to see if we can utilize the existing calibration sketch to detect the orientation settings automatically.

Thanks

@tpitman
Copy link
Contributor Author

tpitman commented Oct 20, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants