Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add conditional style configurator to all demos #748

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

riri
Copy link
Contributor

@riri riri commented Nov 26, 2024

I have added the new style-configurator demo to all platform demos, and tested what I could test (on linux).

There are still a few things that could be improved, that why I suggest we keep that branch for further updates:

  • add a style section for knobs
  • find a way to keep the color table inside the demo function

Other points:

  • during testing, I couldn't make sfml_opengl2 and sfml_opengl3 demos working, because they rely on hard coded paths.
  • the glfw_opengl4 is segfaulting, even without the addition.

Copy link
Contributor

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, looks great.

Outside the scope of this changeset, but I think it would be really cool to be able to click an Export button to send the contents of the style changes to a .h file in your clipboard.

@RobLoach RobLoach merged commit 5dd782c into master Dec 7, 2024
2 checks passed
@riri
Copy link
Contributor Author

riri commented Dec 8, 2024

Outside the scope of this changeset, but I think it would be really cool to be able to click an Export button to send the contents of the style changes to a .h file in your clipboard.

Working on it, I really want to easily provide custom styles to my projects, thanks to @rswinkle feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants