Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nk_roundf() int type casting #742

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fix nk_roundf() int type casting #742

merged 2 commits into from
Nov 22, 2024

Conversation

RobLoach
Copy link
Contributor

@RobLoach RobLoach commented Nov 20, 2024

Was getting a conversion warning on nk_roundf...

include/nuklear.h: In function ‘nk_roundf’:
include/nuklear.h:6630:52: warning: conversion from ‘int’ to ‘float’ may change value [-Wconversion]

@RobLoach RobLoach changed the title Fix nk_roundf() int type casting" Fix nk_roundf() int type casting Nov 20, 2024
@riri
Copy link
Contributor

riri commented Nov 20, 2024

You don't increment de patch version?

@RobLoach
Copy link
Contributor Author

I should likely do that, good call. Would be nice to automate the changelog, eventually.

@RobLoach RobLoach marked this pull request as draft November 20, 2024 22:18
@riri
Copy link
Contributor

riri commented Nov 20, 2024

I thought about it, but it's tricky. How to determine which of patch or minor to increment (major version can't be automated)

@RobLoach RobLoach marked this pull request as ready for review November 21, 2024 04:43
@RobLoach RobLoach merged commit 175ff81 into master Nov 22, 2024
2 checks passed
riri added a commit that referenced this pull request Nov 22, 2024
@Immediate-Mode-UI Immediate-Mode-UI deleted a comment from Sha2561986 Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants