Improve Vulkan demo #717
Merged
Improve Vulkan demo #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my machine (x86_64 Linux, Wayland) VK_SUBOPTIMAL or VK_OUT_OF_DATE_KHR were never returned so the resizing of the swapchain never happened. Fix by using GLFW's resize callback to detect a window resize and a swapchain recreation. Vulkan tutorial uses the same approach. fb_scale was never used in the Vulkan backend, so it was removed.
Over time people have not been noticing that the expected workflow is to build nuklear_glfw_vulkan.h from nuklear_glfw_vulkan.in.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few small things improving the Vulkan demo code.