-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Edit Widget's border area around text #702
base: master
Are you sure you want to change the base?
Conversation
Unless my assumption about "border" is wrong, is it supposed to be outer or inner? seems like it does both, so perhaps only "half" could shrink the area? |
Looks like this was from #592 . Anywhere else we need to update here? Thanks for investigating. |
While this looks okay to me, I think it would be good if we got some others to take a look. Thanks! |
Not sure what is expected in fact, as @ryuukk observed: border is inner, outer, or half the way? I haven't dig in the code parts to check. I pretty agree on a clear definition of bound parts like in CSS, but even there all depends on the box-sizing property, and that's not an easy choice. In one hand, a Choosing in between would make it worse (in my opinion) and nondeterministic because one should always compute content area bound rect on half the border size. Maybe we need to think deeper about it and make tries and guesses. |
Before/After: