Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify rawfb rendering code #624

Closed
wants to merge 1 commit into from

Conversation

ccawley2011
Copy link
Contributor

This should make rawfb maintenance easier in the future.

The SDL code isn't identical to the others yet due to how pixel formats are implemented, but it should be possible to write a basic replacement for SDL_MapRGBA and SDL_GetRGBA in a follow-up PR.

The Wayland code hasn't been tested, but this should restore most of the missing functionality that was disabled in the initial version.

Copy link
Contributor

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Good clean up. Tested both X11 and SDL and they're working. I also don't have a wayland machine to test. Either way, I'd be happy to bring this in unless anyone else objects 👍

@RobLoach
Copy link
Contributor

Another thought... Right now, you'd moved the common rawfb code to demo/common/nuklear_rawfb.h ... Would there be benefit out have having the structure be like...

demo/
demo/rawfb/nuklear_rawfb.h
demo/rawfb/wayland/main.c
demo/rawfb/sdl2/sdl2surface_rawfb.h
demo/rawfb/x11/main.c

While it does stray away from the current set up, it does consolidate all rawfb-related code into that rawfb directory. What do you think?

@RobLoach
Copy link
Contributor

RobLoach commented Apr 4, 2024

@ccawley2011 Pushed up a pull request to follow up with the comment above ccawley2011#2

#629

@RobLoach RobLoach closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants