ColorPicker in GDI Rendring #620
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobLoach
approved these changes
Mar 16, 2024
RobLoach
requested changes
Apr 2, 2024
| @@ -389,7 +389,7 @@ extern "C" { | |||
| #define NK_POINTER_TYPE unsigned __int32 | |||
| #elif defined(__GNUC__) || defined(__clang__) | |||
| #if defined(__x86_64__) || defined(__ppc64__) || defined(__PPC64__) || defined(__aarch64__) | |||
| #define NK_POINTER_TYPE unsigned long | |||
| #define NK_POINTER_TYPE unsigned long long | |||
There was a problem hiding this comment.
The changes in nuklear.h will have to be replicated in the src directory too.
There was a problem hiding this comment.
I'm unsure about changing this as part of the GDI demo updates. Going to recommend pushing that to a different change request.
Suggested change
| #define NK_POINTER_TYPE unsigned long long | |
| #define NK_POINTER_TYPE unsigned long |
RobLoach
reviewed
Apr 4, 2024
| @@ -374,7 +374,7 @@ extern "C" { | |||
| #define NK_SIZE_TYPE unsigned __int32 | |||
| #elif defined(__GNUC__) || defined(__clang__) | |||
| #if defined(__x86_64__) || defined(__ppc64__) || defined(__PPC64__) || defined(__aarch64__) | |||
| #define NK_SIZE_TYPE unsigned long | |||
| #define NK_SIZE_TYPE unsigned long long | |||
There was a problem hiding this comment.
Suggested change
| #define NK_SIZE_TYPE unsigned long long | |
| #define NK_SIZE_TYPE unsigned long |
RobLoach
reviewed
Apr 27, 2024
Comment on lines
+679
to
+681
| /// TODO: 'IStream' {aka 'struct IStream'} has no member named 'lpVtbl'GCC | ||
| stream->Release(); | ||
| //stream->lpVtbl->Release(stream); |
There was a problem hiding this comment.
Looks like there's a remaining TODO?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed a problem with the ColorPicker in GDI rendering.