Minor fixes for GLFW Vulkan Demo #619
Merged
+1
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Vulkan spec states that create_info.minImageCount determines the minimum number of images to create, not the exact count. The count retrieved via vkGetSwapchainImagesKHR can (and in my case does) differ - without penalty to the rest of the demo.
|
LGTM ✔️ |
RobLoach
approved these changes
Mar 16, 2024
RobLoach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes I needed for the glfw_vulkan demo to function in a reasonable manner (launch + window resizing) on my Void Linux machine.
40a172b- It is valid to continue a render process in the event thatvkAcquireNextImageKHRreturnsVK_SUBOPTIMAL_KHR. The implementation already correctly handles recreating the swapchain when necessary so no other changes were needed beyond preventing the error-out.03aa308- Vulkan may create more swapchain images than requested viaminImageCounttovkCreateSwapchainKHR. In my testing on two different machines,vkGetSwapchainImagesKHRwas returningminImageCount + 1when queried, causing me to hit this error-out. The demo works without any other changes beyond preventing the error-out.https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkCreateSwapchainKHR.html
https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkSwapchainCreateInfoKHR.html
@m0ppers Since you added Vulkan, can you double-check me on this?