Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a style option to disable point markers on charts #602

Merged

Conversation

brianwatling
Copy link
Contributor

With point markers enabled (default):
with_markers
With point markers disabled:
without_markers

Fixes #594

Copy link
Contributor

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! Nice work.

@dumblob
Copy link
Member

dumblob commented Feb 17, 2024

Looks good to me in general. My personal preference would be to use a non-negated form (nk_bool show_markers; instead of nk_bool hide_markers;) but I would be fine merging if others will not agree 😉.

@RobLoach
Copy link
Contributor

That's a good point. Would it be possible to default nk_bool show_markers to nk_true when initializing the struct?

@RobLoach RobLoach self-requested a review February 17, 2024 18:13
@brianwatling
Copy link
Contributor Author

That's a good point. Would it be possible to default nk_bool show_markers to nk_true when initializing the struct?

Done - renamed to show_markers and defaults to nk_true to preserve existing default behaviour (and tested that)

Copy link
Contributor

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. Thanks so much.

@RobLoach RobLoach merged commit 34ea8bb into Immediate-Mode-UI:master Apr 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line chart performance: boxes on points make line charts much slower than without
3 participants