Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Commit

Permalink
bug in paging semantics
Browse files Browse the repository at this point in the history
  • Loading branch information
brockallen committed Feb 27, 2014
1 parent 19fdde9 commit 4fac139
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,17 @@ public IEnumerable<string> GetRolesForUser(string userName)

public IEnumerable<string> GetUsers(int start, int count, out int totalCount)
{
if (start < 1) start = 0;
if (count < 0) count = 10;
start = (start - 1) * count;
return userQuery.Query(userSvc.Configuration.DefaultTenant, null, start, count, out totalCount).Select(x => x.Username);
}

public IEnumerable<string> GetUsers(string filter, int start, int count, out int totalCount)
{
if (start < 1) start = 1;
if (count < 0) count = 10;
start = (start - 1) * count;
return userQuery.Query(userSvc.Configuration.DefaultTenant, filter, start, count, out totalCount).Select(x => x.Username);
}

Expand Down

2 comments on commit 4fac139

@galenp
Copy link

@galenp galenp commented on 4fac139 Mar 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Brock

Just evaluating the MembershipRebootUserRepository for integration into ThinkServer v2.

This commit breaks /Admin/User in ThinkServer web admin.

image

@brockallen
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this is now fixed. Basically we had 2 (or even 3) different paging semantics. I think they're all on the same page now (ba da bum).

Please sign in to comment.